This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Enable S3 storage. #433
Closed
Enable S3 storage. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
force-pushed
the
fix-4456
branch
2 times, most recently
from
3c700da
to
8319f42
Compare
fao89
reviewed
Oct 16, 2019
pulp_docker/app/registry.py
Outdated
| file_response = web.FileResponse(path, headers=full_headers) | ||
| return file_response | ||
| elif settings.DEFAULT_FILE_STORAGE == 'storages.backends.s3boto3.S3Boto3Storage': | ||
| raise HTTPFound(file.url, headers=headers) |
There was a problem hiding this comment.
Suggested change
| raise HTTPFound(file.url, headers=headers) | |
| raise HTTPFound(file.url, headers=full_headers) |
pulp_docker/app/registry.py
Outdated
| n=os.path.basename(path)) | ||
| file_response = web.FileResponse(path, headers=full_headers) | ||
| return file_response | ||
| n=os.path.basename(file.path)) |
There was a problem hiding this comment.
Suggested change
| n=os.path.basename(file.path)) | |
| n=os.path.basename(file.file.name)) |
pulp_docker/app/registry.py
Outdated
|
|
||
| """ | ||
| full_headers = MultiDict() | ||
|
|
||
| full_headers['Content-Type'] = headers['Content-Type'] | ||
| full_headers['Docker-Content-Digest'] = headers['Docker-Content-Digest'] | ||
| full_headers['Docker-Distribution-API-Version'] = 'registry/2.0' | ||
| full_headers['Content-Length'] = os.path.getsize(path) | ||
| full_headers['Content-Length'] = file.size |
There was a problem hiding this comment.
Suggested change
| full_headers['Content-Length'] = file.size | |
| full_headers['Content-Length'] = str(file.size) |
closes #4456 https://pulp.plan.io/issues/4456
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4456
https://pulp.plan.io/issues/4456